Skip to content
Submitted 4 months ago

I used flexbox

Alan Joel Murillo•10
@AlanJoelMurillo
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud of finally center a div, I used flex-box for the first time and it was great, maybe next time I would do it with grid

What challenges did you encounter, and how did you overcome them?

I had to watch a 3hr css course because it's my first time using real css

What specific areas of your project would you like help with?

I'm not really sure if I should have used rem or em instead of px, but I dont know where I should use them and where not to.

Community feedback

  • Alex•3,130
    @Alex-Archer-IPosted 4 months ago

    Hi!

    I see you did a triple challenge, that's a creative approach =)

    But I really recommend you to put links inside a head. It'll improve the speed of page loading and you wouldn't have to do it three times.

    As for your question about rem vs px there is a good article about it. It's a bit advanced, but the main idea that you definitely should use rem for font sizes and for values which should changes with it.

    Also I can suggest you to use semantic tags more. Every page should contain main tag. The bold text here should be the title - h1 tag, and the smaller text is paragraph - p.

    So, congrats with you first challenge, keep doing great stuff =)

    Marked as helpful
    1
    Alan Joel Murillo•10
    @AlanJoelMurilloPosted 4 months ago

    @Alex-Archer-I yeeei thank you for the fedback I appreciate it, I'll try what you say about the tags, and also al read the rem article, Thanks so much 😁

    1
    Alex•3,130
    @Alex-Archer-IPosted 4 months ago

    @AlanJoelMurillo

    You're welcome =)

    Fell free to ask anything if need =)

    0
  • OMG•20
    @artsupawatPosted 4 months ago

    Great! it look good to me. Your code is well-organized

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord