Skip to content
Submitted over 1 year ago

I used CSS Grid and Floats

Caue Costa•30
@Bluecaue
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I didn't have many difficulties, I don't even know if I had any

Community feedback

  • Andrea Y Costas•190
    @a-costasPosted over 1 year ago

    Hi there! Congratulations on finishing the challenge!

    My one note would be regarding semantic HTML. Instead of using <div> for the main content, I'd encourage you to use <main> instead. Similarly, while I know you commented out the attribution portion, that would be a perfect time to use <footer>. These may seem like small and insignificant choices, but they can be very helpful to maintain good accessibility across your site as well as maintaining good code. One day, it can even be helpful in improving SEO positioning.

    All in all, nice work and happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord