I used CSS Grid and Flex but mostly Grid with Grid-template-area
Design comparison
Solution retrospective
- Still have issues with Media Queries.
Community feedback
- @brianlfarmerllcPosted over 3 years ago
Hi there looks really good but I have two suggestions.
To help with the mobile layout you should look into the built in responsiveness that css grid can provide. I found this article very helpful. https://css-tricks.com/look-ma-no-media-queries-responsive-layouts-using-css-grid/
and second consider creating a 4 row template on the container where the bottom one would hold your social icons. This would help with getting the icons closer to the bottom of the page.
Keep up the great work!
1 - @palgrammingPosted over 3 years ago
you should try setting the "background-repeat: no-repeat" setting for the background images https://www.w3schools.com/CSSref/pr_background-repeat.asp
1 - @tedikoPosted over 3 years ago
Hello, Jean Pierre Bizimana! 👋
Well done on this challenge! In addition to palgramming and brianlfarmerllc feedback here's a few things I'd suggest you to take a look at:
- Change the
alt
attributes for the.logo
,.ilustrations
images, as they don't add any extra context for screen reader users. Since your images are decorative youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies. - Wrap your icons with anchor tag
<a>
to make them clickable. Additionaly you'd have to add somearia-label
on it to describe it for screen readers users since icons are treated like there is no content within anchors so it won't be announced.
Keep up the good work! 💪
0 - Change the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord