Design comparison
Solution retrospective
it was an easy test
What challenges did you encounter, and how did you overcome them?i didnt have any diffuculties
What specific areas of your project would you like help with?it's a simple project
Community feedback
- @Islandstone89Posted 8 months ago
HTML:
-
Every webpage needs a
<main>
that wraps all of the content, except for<header>
andfooter>
. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change.container
to a<main>
. -
Headings should always be in order, so you never start with a
<h3>
. Also, "Learning" is not a heading, but a paragraph. -
Replace
<span>
with<p>
, and use the<time>
element for the date:<p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>
. -
The profile image needs a short, descriptive alt text, like "Headshot of Gary Hooper".
CSS:
-
.figtree
is not a class given to any HTML elements, so those declarations don't do anything. Also, you don't need thosefont
properties, andfont-family
should be placed on thebody
, not*
. -
Including a CSS Reset at the top is good practice.
-
Add around
1rem
ofpadding
on thebody
, so the card doesn't touch the edges on small screens. -
Remove the margin on the card. Do not use
%
for margins. -
To center the card horizontally and vertically, use Flexbox on the body:
display: flex; flex-direction: column; justify-content: center; align-items: center; min-height: 100svh;
-
Remove the width and height on the card.
-
Add a
max-width
of around20rem
on the card, to prevent it from getting too wide on larger screens.
0 -
- @miguel0920Posted 8 months ago
- separate the texts from each other
- use semantic html
- add border-radius to 'Learning' tag
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord