I use Vanilla Js and Css

Community feedback

• 

  Duvan Rodriguez•120

  @TkDevkPosted 11 months ago

  I'm looking the screenshot and looks totally different :c, someone knows why?, i have two monitors and looks good in them.

  0

  ---

  

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  @TkDevk You have the option to generate a new screenshot in the DESIGN COMPARISON part, it should look like a red button that says GENERATE NEW SCREENSHOT.

  Marked as helpful

  0

  

  Duvan Rodriguez•120

  @TkDevkPosted 11 months ago

  @Blackpachamame

  Thank you so much it worked. Sorry i have a question, for the challenges it is better to use 100vh ? or 100%?, i sue 100vh but for some challenges the output it looks weird.

  Thanks in advance for your response : )

  0

  

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  @TkDevk Always try to use min-height unless you need a fixed height. What happens if you set a height: 100vh is that if the content of your page exceeds the height of the viewport then you will see it cut off, however, with min-height you can scroll and see the rest of the content.

  Regarding which unit to use, it is very relative and the truth is I never delved into the subject because I am very comfortable using min-height: 100vh 😅

  In any case, CSS is advancing and new units are appearing that are better for specific cases. I share with you a very good YouTube channel, where they talk a lot about the subject and in a very clear way, maybe you can take a look at it: Kevin Powell /search?query=vh

  0

  

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  @TkDevk Hello, you already received wonderful feedback on this challenge. I just wanted to mention that the screenshots are taken simulating a device with a width of 1440px and a height of 800px. Keep that in mind and try using DevTools to simulate a device of those dimensions, and you'll see that the screenshot is identical.

  1

  

  Duvan Rodriguez•120

  @TkDevkPosted 11 months ago

  @Blackpachamame Thank you 😀

  1

  

  Duvan Rodriguez•120

  @TkDevkPosted 11 months ago

  @MelvinAguilar Wonderful, thanks so much for your help

  1