Skip to content
Submitted over 3 years ago

I use HTML, SASS AND JS

Francisco•145
@Frankiiize
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Intro component with sign-up form
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello, dev friends!, Challenge ready, if someone can give me their opinion, give me some tips, I'm a newbie in programming, I'm not really sure if the validation of my form is correct or it would have some errors.

Community feedback

  • Mojtaba Mosavi•3,760
    @MojtabaMosaviPosted over 3 years ago

    Hi, you done good job on styles but there is room for improvment in the markup.

    1- Writing semantice markup is most improtant priciples in writing htmtl, it's not always a easy task. Whenever your writing markup think about what functionality the markup is trying to achieve. For instance the button on top of the form is an interactive element so the appropriate markup for it has to have so kind of interactive behavior like button or link.

    2- if your are using bem remember that you cannot nest elements.

    Keep coding :)

    Marked as helpful
    1
    Francisco•145
    @FrankiiizePosted over 3 years ago

    @MojtabaMosavi its a link/button ^.^! , jaja thanks i don't know why i thought it was just a card, i'll change it

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord