Design comparison
SolutionDesign
Community feedback
- @grace-snowPosted about 4 years ago
This looks nice. I think you're switching to desktop layout a bit early and that's causing problems on mobile landscape layout (I'll add a screenshot in slack for you)
I also suggest
- not having images in a section or wrapping all the content in an outer section (try main)
- styling on classes not ids
- changing height to min-height on your background gradient so it can go bigger when needed
- making animations a bit faster (maybe just remove delay? )
- allowing users to open more than one accordion at once. This is standard behaviour in collapsible section ui these days, as opposed to tabs which are for showing one bit of content at a time
- looking into aria roles like aria-collapsed and learning how to apply them to this ui
Hope that's helpful feedback, keep. Going
1 - @OmkarTanawadePosted about 4 years ago
This is looks amazing great but issue I faced was. Svg in desktop settings don't get load complety I will share you a screenshot. The rest work is good. https://faq-accordion-card-gold.vercel.app/ Take a look at desktop version
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord