Skip to content
Submitted over 1 year ago

i use css flexbox and other properties

christopher•190
@umahichristopher
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

i appreciate feedback. thank you

Community feedback

  • Atif Iqbal•3,200
    @atif-devPosted over 1 year ago

    Hi christopher, congrats🎉 on completing the challenge. Better take care about following points.

    • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. Use alt (alternate text) attribute as it is mentioned in your Accessibility Report. alt attribute is used for Screen readers technology. Why alt attribute matters? Read here. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

    (why main matters? Read here)

    • Instead of using margins, use following block of code for centering:
    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
    • In your solution card looks much bigger on larger screens, you need to fix this.

    Hope you will find this Feedback Helpful.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord