Atif Iqbal• 3,200
@atif-dev
Posted
Hi christopher, congrats🎉 on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. Use
alt(alternate text) attribute as it is mentioned in your Accessibility Report.altattribute is used for Screen readers technology. Whyaltattribute matters? Read here. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
(why main matters? Read here)
- Instead of using margins, use following block of code for centering:
body {
min-height: 100vh;
display: grid;
place-content: center;
}
- In your solution card looks much bigger on larger screens, you need to fix this.
Hope you will find this Feedback Helpful.
0
