I try to do a Dark Version

Community feedback

• 

  Dimitar Radev•930

  @Mitko90Posted over 1 year ago

  Hi, nice solution.

  I love 🖤️ the dark theme

  Maybe you can check some suggestions I have for you:

  • You used three times the <h1> heading. This heading should only be used once. Maybe change it to <h2> as it can be reused. Of course every page should have an h1 heading so I suggest adding a visually-hidden one to the page, so it doesn't generate an accessibility report.
  • Your buttons should direct the user to a different part or page of the site. So maybe switch the <button> with the <a> tag.

  I had the exact same mistakes when I did this challenge so I redid it with the changes. You can, if you want, check both of my submissions here and here.

  Above all the solution you submitted looks great.

  Happy coding.

  Marked as helpful

  0

  ---

  

  Pedro Henrique Ribeiro•170

  @class-pedroPosted over 1 year ago

  @Mitko90 thank you help! Your suggestions helped me a lot, especially about the <button> :O

  Thank you again!

  1