Qr code

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with QR CODE is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Khawar Mehfooz•530

  @KhawarmehfoozPosted over 1 year ago

  Hi! 👋 Congratulations on completing the challenge!

  I have some suggestions to improve the solution:

  • Add the following CSS properties to the body to properly center the content in the middle of screen:

  height:100vh;
  display:grid;
  place-items:center
  

  • To properly resize the qrcode-box use the width: 325px.

  Happy coding!

  0