Skip to content
Submitted about 2 years ago

i think i used a lot of unnecessary divs

Gabriel Coelho•240
@BielCoelho
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I think I used too much divs trying to use rem, em as other guy said in other challenge I sent. had a bit of trouble trying to fix the pointer in the last two buttons but I got it. also struggle a bit centering two lines of text with the song icon

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @BielCoelho, great job on this project!

    1. To make it easier to deal with rem/em, you can simply divide the value by 16. If your using VSCode you can download the extension px to rem. Of you can use website that will convert it for you.

    Happy Coding!

    0
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @BielCoelho, Congratulations on completing this challenge!

    Nice work! Now you miss only the background wave

    The background wave image is missing and here’s the step-by-step to add it.First of all add the image as a background inside the body this is the code for that: background-image: url(../images/pattern-background-desktop.svg);

    Then you add background-repeat: no-repeat to avoid the background repeating and background-size: contain to make it fit full width and center with the card this is the best choice, but an alternative to resize it is to use background-size: 125%, Here’s the code with the modification and the image applied as background:

    body {
    background-color: var(--pale-blue);
    background-size: contain;
    background-image: url(./images/pattern-background-desktop.svg);
    background-repeat: no-repeat;
}

    ✌️ I hope this helps you and happy coding!

    0
  • Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    Hi Gabriel Coelho, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord