I refers w3schools to built this project

Community feedback

• 

  Patrick•10

  @pmahon628Posted 5 days ago

  Hi Sham - do you have a deployed link? I am not seeing anything for your solution aside from a header that says frontend-mentor-projects. I look forward to seeing your solution.

  0

  ---

  

  Sham•20

  @JOYBOi3D2YPosted 5 days ago

  @pmahon628 yeah! I stuck up with some error. Soon I will resolve it and Thank you for feedback!!!

  0

  

  KapteynUniverse•2,170

  @KapteynUniversePosted 4 days ago

  @JOYBOi3D2Y You need to put the folder name where html file is in at the end.

  https://joyboi3d2y.github.io/frontend-mentor-projects/qr-code-component-main/

  Now, you didn't asked for a feedback but since i started :D

  To center the card you can use flex or grid

  body {
      background-color: hsl(212, 45%, 89%);
      min-height: 100vh;
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center; 
  }
  

  margin: auto; on the card is unnecessary after this.

  You can also apply font-size, weight etc. to the body and change on the elements where it is needed to change. Also font-weight: weight; is not a correct property value. You can check the values on here

  It's important to make sure that your website is accessible to all users, including those using assistive technologies such as screen readers.

  Landmarks, (or this page) are essencial for accesibility. Every page needs one main. Wrapping your card div with a main would be good.

  Image alt texts needs to be meaningful, unless decorative. Instead of an "qr-code" you can write something like "QR code to Frontendmentor.io" so screen readers can understand the context.

  Avoid hard coded values like width: 300px;, this will cause responsive issues in the future use max-width: 300px; instead. Using max-width: 18.75rem; would be even better for responsiveness. Use rem especially for font size and media queries. This video might give you an idea about rem units.

  I also recommend you to use a modern css reset or Andy Bell's reset for every project.

  0

  

  Sham•20

  @JOYBOi3D2YPosted 4 days ago

  @KapteynUniverse Thanks a lot for this feedback it helps me to write code effective 👍

  1