Design comparison
Solution retrospective
Thanks for checking this out
I put a transitions on hover, but I'm not sure this is the right approach.
"If you have any suggestions or feedback for my code, please feel free to comment." I would greatly appreciate all feedback.
Community feedback
- @DudeldupsPosted over 1 year ago
Heya! This looks good! Two things I saw:
- For the hover state of the image, you can use the
::after
pseudo element with
background: #color url(eye-image) center no-repeat;
And then use
opacity
transition to show or hide it on hover. This way, the "eye" icon also transitions :)- You used way too many
flex
containers. For the div where the price and remaining days are shown, you can put all of that in a div, give it agap
and usemargin-right: auto
on the price. This way, it pushes the other elements all the way to the right :)
Marked as helpful0@CGM-ThanHtikePosted over 1 year agoThank you for the feedback @Dudeldups. I just fixed with opacity and it looks way better. And for the margin-right: auto method, I was try that before but the problem is, I was struggling with aligning icons and text vertically (that's why I used flex also for it).
0 - For the hover state of the image, you can use the
- @adepoju-oluwatobiPosted over 1 year ago
I love the transition effects... cool!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord