I only used html and css with vs code

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the element <div class="container"> the with semantic element <main> along with <div class="attribution"> for <footer> a in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Jemuel Anacio•20

  @SCUEEDPosted over 1 year ago

  @0xAbdulKhalid Thank you very much for the tip, I'll practice more to make my codes more semantic.

  0
• 

  Elio Flores•400

  @eliofloPosted over 1 year ago

  Great job! Your solution looks great!

  As some of the other comments have mentioned, you can further improve your page by using media queries to make it responsive. Another way to make your page responsive is by using percentage values for the width property. This allows the element to adapt to different screen sizes and take up a percentage of its parent container's width. For example:

      .responsive-box {
          width: 100%;
          max-width: 800px;
      }
  

  This will cause the box to adjust its width to the size of the viewport, until the viewport is wider than 800px, at which point the box will stop growing in size.

  Here are some alternatives for centering an element: you can use position (as you have done), flex, or grid.

      // WITH FLEX
      .center {
          display: flex;
          justify-content: center;
          align-items: center;
      }
      
      // WITH GRID
      .center {
          display: grid;
          place-items: center;
      }
  

  I hope this helps! If you have any questions, feel free to ask.

  Elio Flores

  Marked as helpful

  0

  ---

  

  Jemuel Anacio•20

  @SCUEEDPosted over 1 year ago

  @elioflo Thank you for the tips and alternatives! To be honest, centering an element is quite difficult at some point.

  0
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Your app looks great! Congrats on completing the challenge successfully!

  "Any secret tips on making a web page responsive depending on the screen size?"

  It not really a secret, but you can use media queries for making your layout and css values change based on screen size, simply add:

  @media (max-width: 375px) { .your-classname-here { your-css-property: your-css-value;} }

  this tells, up to screen-size of 375px width, use these values for this css property of this html element. Change the px according to your needs, like for tablet etc. as well. You can read more here: https://www.w3schools.com/css/css_rwd_mediaqueries.asp

  Hope you find this feedback helpful!

  Marked as helpful

  0

  ---

  

  Jemuel Anacio•20

  @SCUEEDPosted over 1 year ago

  @visualdenniss Thank you! I will look upon media queries, thanks for the tip!

  0