@BernardusPH
Posted
Hello SAMUEL MAKINDE
This is a great submission, I just want to give some feedback:
Please don't use a div as a landmark without reason(like a framework). What I mean is, the DIRECT children of the body. There are a few landmarks like
- nav
- main
- footer
- aside etc.
For your project I would just replace the direct children of the body (the two divs) into main
and footer
respectfully. The reason for this is for the developers so we don't get easily lost in the code and also screen readers use the landmarks.
A piece of advice for the image. You don't have to change the height of an image all the time since it (USUALLY) scales with the width like yours, remove the height and you will see no difference.
Also try using %
on the image so you don't have to guess the size every time, I used the width:100%
and it looked the same but much easier to manage.
Hope this helped.
Marked as helpful
@Samuel-Makinde
Posted
@BernardusPH Your comment is really helpful...Thanks