Design comparison
Solution retrospective
I have difficulty in solving this project, this my 2nd project. I hope you can help me to improve thi much better
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semantic
markup, which causes lacking of landmark for a webpage
- So fix it by replacing the
<div class="container">
element with the semantic element<main>
along with<div class="attribution">
into a<footer>
element in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
- For example:
- The
<main>
element should include all content directly related to the page's main idea, so there should only be one per page - The
<footer>
typically contains information about the author of the section, copyright data or links to related documents.
- The
HEADINGS β οΈ:
- This solution has also generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
CSS π¨:
- let me explain, How you can easily center the component for better layout.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here π.
- For this demonstration we use css
Grid
to center the component
body { min-height: 100vh; display: grid; place-items: center; }
- Now remove these styles, after removing you can able to see the changes
.container { margin: 5rem auto 0; }
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@dhpcodePosted over 1 year ago@0xAbdulKhalid thanks my friend for your comment, I will improve my challenge with your advice!!!
0@0xabdulkhaliqPosted over 1 year ago@davrsirius if you found it helpful then feel free to mark it as helpful my brother π
Marked as helpful0@dhpcodePosted over 1 year ago@0xAbdulKhalid Thank you for links you shared, I've found it useful! I'm new in this sphere. Please give your feedback for my next challenges!!!
0@0xabdulkhaliqPosted over 1 year ago@davrsirius
Glad to hear that!
Yeah sure i'm here to give valuable feedbacks to you and our frontendmentor community
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord