Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

I just used HTML & CSS. send me feedback, please?

hamid Mola 120

@hamidMolaDev

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


hey Guys, send me feedback, please? i really need friend in the community, let's help each other. 😅

Community feedback

P
Scott 240

@scottmotion

Posted

A couple things I noticed Hamid:

On the main element you should remove min-height: 70vh.

The grids are overflowing in Chrome Inspector, you can try this:

.profile {
    display: grid;
    grid-template-columns: 45px auto;
}

Alternatively you could make the element a flex row.

I recommended to another user that they make a wrapper around each testimonial:

<div class="people">
    <div class="testimonial__wrapper">
        ...Testimonial elements here...
    <div>
</div>

.testimonial__wrapper {
    display: flex;
    flex-direction: column;
    justify-content: space-between;
    gap: 1rem;
}

If you use space-between and gap it will stretch the div and you don't need margin/padding on the inner testimonial elements. You might need to add flex column to the people div in your layout.

Marked as helpful

0

hamid Mola 120

@hamidMolaDev

Posted

Hello @scottmotion, "On the main element you should remove min-height: 70vh." i give it min-height because i wanted to centered the main when i use full screen and beside of that it's just a one content in page. but your recommendation was awesome and helpful, thank you for everything man. 👍🙏

0
hamid Mola 120

@hamidMolaDev

Posted

one more thing @scottmotion, how you put code it feedback? how it works?

0
P
Scott 240

@scottmotion

Posted

@hamidMolaDev its a bit tricky. use 3 backtick characters before and after, on separate lines.

(backtick)(backtick)(backtick)

some code

(backtick)(backtick)(backtick)

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord