i have using css flex box

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Normally, <div class="button"> should be a button since it triggers an action, which is adding the product to the shopping cart. Additionally, you shouldn't use the link solely for containing the text; clicking the element should perform an action, not just the text being the link.

  • The alt attribute is used to provide a text description of the image which is useful for screen reader users, assistive technology users, and search engine optimization. Add the alt attribute to the <img> tag of the product.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  0

  ---

  

  minu-arch•40

  @minu-archPosted 11 months ago

  @MelvinAguilar Sincerely, I didn't know about this. Now I know. Thanks, buddy

  1
• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 11 months ago

  Hello there @minu-arch 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  CSS and Styling:

  • Avoid using px for font-size, you could read this article to learn why. Letter spacing and line height must not be in px, use rem for all the font-related properties.
  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design. Like the image, set the parent to a max-width: 50%, and let the image to adapt width object-fit

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  Marked as helpful

  0

  ---

  

  minu-arch•40

  @minu-archPosted 11 months ago

  @AGutierrezR you're right. I am grateful because you told me this, and I forgot to change it to rem. Initially, I wrote it with px because it's easier for me, and after that, I converted it to rem.

  0