Design comparison
Solution retrospective
give me the best way to complete this project?
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @silentknight06!
Your solution looks great!
I have a suggestion for improvement:
- Use
<main>
to wrap the main content instead of<div>
.
š Think of
<div>
and<span>
in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 - Use
- @rawannmmohamedPosted 9 months ago
hello,
you can give the scanner div a fixed width of pixels I recommend 300px.
and you forgot to add the font family to the texts.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord