i have completed this challenge with help of html and css

Community feedback

• 

  Yazdun•1,310

  @YazdunPosted about 3 years ago

  Hello Aditya 👋 ! So here are some quick fixes that came to my mind :

  • You only need to specify font-family on the body and other elements will inherit it, you won't need to specify it on each and every element.
  • Approach mobile-first it will definitely makes your life much easier !
  • set background-repeat to no-repeat and background-size to cover, Your background doesn't look much good on wider screens.
  • Use prettier extension on your IDE to format your code much cleaner.
  • each page should have at least one main tag which wraps the whole page's content and this main tag, must have a level one heading which tells what this page is about, this h1 can be hidden. Fix this and your accessibility issues will be gone

  ✅ Also I opened a pull request to your github repository which contains these quick fixes

  I hope this was helpful

  Marked as helpful

  0

  ---

  

  aditya uchiha•80

  @adityaauchihaPosted about 3 years ago

  @Yazdun thanks a lot, for your suggestions. i, will definitely work on it. mobile responsive is going little difficult for me and adjusting background images. i, will work on it. :)

  0