I finished this project with HTML and scss. Feedback welcome.

Community feedback

• 

  Laharl•1,000

  @UrbanskiDevPosted about 2 years ago

  Hello willie !

  Congratulation for finishing the project

  Some suggestions to make it better :

  1. You can see that your market icon is bigger than the one provided on the design, you can set up a width and an height to limit the size

  .svg-cart {
    margin-right: 10px;
    max-width: 28px;
    width: 18px;
    height: 18px;
  }
  

  2. When testing your responsive, you can see there's some problems, for example the width of the button with a size screen of 694px. You can add a max-width, in order to avoid making some elements way too big !

  .atc {
    display: flex;
    flex-direction: row;
    background-color: hsl(158deg, 36%, 37%);
    border: none;
    border-radius: 0.45rem;
    color: hsl(0deg, 0%, 100%);
    width: 100%;
    height: 40px;
    padding-top: 10px;
    padding-left: 80px;
    max-width: 300px;
  }
  

  3. With the same idea from the precedent point, you should also add a min-width to avoid your element to shrink too much in size/ to be too small !

  Hope my comments helps you, keep learning !

  Marked as helpful

  0

  ---

  

  Willie Morris•60

  @willie10rPosted about 2 years ago

  @UrbanskiDev Thank you i'll take your advice and adjust them.

  0