Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

I finished this project with HTML and scss. Feedback welcome.

@willie10r

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback is welcome. I'm looking forward to your feed back on what I could improve.

Community feedback

Laharl 1,000

@UrbanskiDev

Posted

Hello willie !

Congratulation for finishing the project

Some suggestions to make it better :

  1. You can see that your market icon is bigger than the one provided on the design, you can set up a width and an height to limit the size
.svg-cart {
  margin-right: 10px;
  max-width: 28px;
  width: 18px;
  height: 18px;
}
  1. When testing your responsive, you can see there's some problems, for example the width of the button with a size screen of 694px. You can add a max-width, in order to avoid making some elements way too big !
.atc {
  display: flex;
  flex-direction: row;
  background-color: hsl(158deg, 36%, 37%);
  border: none;
  border-radius: 0.45rem;
  color: hsl(0deg, 0%, 100%);
  width: 100%;
  height: 40px;
  padding-top: 10px;
  padding-left: 80px;
  max-width: 300px;
}
  1. With the same idea from the precedent point, you should also add a min-width to avoid your element to shrink too much in size/ to be too small !

Hope my comments helps you, keep learning !

Marked as helpful

0

@willie10r

Posted

@UrbanskiDev Thank you i'll take your advice and adjust them.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord