I developed one of the Frontend Mentor challenges using HTML and CSS.

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="container"> instead of <div class="container">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  0

  ---

  

  Alejandra Olazagasti•100

  @AlejandraOlazagastiPosted over 2 years ago

  @Samadeen I really appreciate your comments.

  Thanks for taking the time to read my code! 🙏

  0
• 

  Danilo Blas•6,300

  @Sdann26Posted over 2 years ago

  Alejandra congratulations for finishing this project!

  What I wanted to mention is that your project is very well proportioned but the reason why your design was small is that the paragraph should have font-size: 15px and you gave it to the title. That's why in the end it was smaller.

  On the other hand to fix the accessibility problems you have just change <div class="container"> to <main class="container">, since you should always have a main tag with the main content of the page.

  Also change the h2 for an h1 because if you don't have an h1 your project will give you an accessibility error since you should always have only one per page of your project.

  That would be all, I hope my comments are helpful.

  Good Coding!

  Marked as helpful

  0

  ---

  

  Alejandra Olazagasti•100

  @AlejandraOlazagastiPosted over 2 years ago

  @Sdann26 I really appreciate your comments. They are very helpful to improve my code.

  I will continue developing challenges with the aim of continuing to learn and improve.

  Thanks for taking the time to read my code! 🙌

  1