I developed one of the Frontend Mentor challenges using HTML and CSS.

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Alejandra Olazagasti! 👋

  Great work on this challenge! Your solution looks pretty good! 😀

  I see some areas in your code that you can improve.

  • I would not recommend wrapping the anchor tag with a form tag. I recommend using form element when there's data that needs to be submitted. The link element is used to navigate the users to another page or website (no submitting).
  • figure element doesn't need to wrap every img element. The only reason to use figure is if you need to include a figcaption. Otherwise img tag is fine.
  • The illustration and the icon music are decorative images. So, I would recommend leaving the alt="" empty to hide those images from screenreader users. By doing this, it will make sure that the screenreader users focus on the main content of the site.

  Hope this helps. 🙂

  Marked as helpful

  0

  ---

  

  Alejandra Olazagasti•100

  @AlejandraOlazagastiPosted over 2 years ago

  @vanzasetia I really appreciate your comments. They are very helpful to improve my code.

  I will continue developing challenges with the aim of continuing to learn and improve.

  Thanks for taking the time to read my code! 🙌

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @AlejandraOlazagasti You're welcome! 😄

  Marked as helpful

  0