I Developed a responsive FAQs page using HTML, CSS and Javascript
Design comparison
Solution retrospective
Hello Devs, Checkout my solution to the frontend mentor faq-accordion challenge. How well have i done?
Community feedback
- @0xabdulkhaliqPosted almost 2 years ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- Your solution generates accessibility error reports due to usage
non-semantic
elements
- So hereafter use semantic elements such as
<main>
instead of<div class="container">
to improve accessibility and organization of your page.
- By declaring
main
you need not to use any ARIA landmarks such asrole="main"
- Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
0@DegreatisaacPosted almost 2 years ago@0xAbdulKhalid Thank you, this is helpful. I will work on improving my code accessibility.
0 - @Finney06Posted almost 2 years ago
Hello there π. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
-
Wrap the page's whole main content in the
<main>
tag. -
Always avoid skipping heading levels; Starting with
<h1>
and working your way down the heading levels (<h2>
,<h3>
, etc.) helps ensure that your document has a clear and consistent hierarchy. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections. -
Use ARIA landmarks such as
<header role="banner">
and<footer role="contentinfo">
to provide additional information about the purpose of each section to assistive technologies.
Here is a web accessibility evaluation toolπ to check your webpage for any remaining errors or warnings related to landmarks.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
0@DegreatisaacPosted almost 2 years ago@Finney06 Thank you for your reply. This is very useful to me, I will work on them to improve my code. Thank you.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord