@HammadHamdani
Posted
Designed very well but some improvements that can be done are:
Suggestions:
- Make the body text a bit dark to make it properly visible.
- Remove the footer(copyright) section because it doesn't look good.
- And still if you want to add copyright section to your solution page than make it out of the actual design like at the footer of page.
Marked as helpful
@benjamineke
Posted
@HammadHamdani Thank you for your suggestions I appreciate it 😁, but the actual design I notice that the color of the text at the body is a bit dark blue and base on the style guide provided by the Frontend Mentor that's the one provided color there and also the footer(copyright) it seems that I didn't put it there automatically because when I downloaded the folder, there was already a copyright notice in the index.html file. So, I didn't remove it; instead, I just changed the author, and that was me.
@HammadHamdani
Posted
@benjamineke Yes you are right. I know that index.html
file contains a copyright section by default in every challenge. But it will look good if you place it at bottom of page. By the way it's just my own opinion.
Marked as helpful
@benjamineke
Posted
Thank you @HammadHamdani I change it now and I'm sorry for mis-understanding about what you want of the footer(copyright) I added it now thank you again.
@HammadHamdani
Posted
@benjamineke No thanks. Its my pleasure that my feedback was helpful for you.
Marked as helpful