I centered divs and included contents to divs

Community feedback

• 

  Arthur Roberts•410

  @arfarobsPosted over 2 years ago

  Hey Vedat. It's looking good. I have a few suggestions for you.

  Accessibility:

  1. All of you images should have an alt attribute with a description of what is in the image as a value. For decorative images like the icons, Id suggest giving them an empty alt attribute. https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/alt

  2. As Shashree mentioned above, your content should be wrapped in a <main> element. I also noticed that you wrapped the heading in a <p> element. I suggest that you change that to an <h1> element. All webpages should have an <h1> element. The link below explains the best practices when using headings. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements

  Flexbox:

  1. You said you had issues with flexbox. I will leave two links below. These links are games in which you use flexbox as the controls. They are great for practicing flexbox. They're also quite fun and explain a lot to you. https://flexboxfroggy.com/ http://www.flexboxdefense.com/

  I hope this helps you. I have also completed this challenge. I used flexbox in my solution. Feel free to refer to it.

  Marked as helpful

  0

  ---

  

  Vedat Sözen•230

  @vedatsozenPosted over 2 years ago

  @arfarobs Thanks for your help. I ll try to make better in new challenges. As main div, or alt for images.

  1

  

  Arthur Roberts•410

  @arfarobsPosted over 2 years ago

  @vedatsozen You're welcome.

  0
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge, keep up the good work

  Your solution looks great however I think the content needs some padding in the card as seen in the design

  In terms of accessibility issues simply wrap all the content between main tags

  I hope this helps

  Cheers

  Happy coding 👍

  0

  ---

  

  Vedat Sözen•230

  @vedatsozenPosted over 2 years ago

  @TheCoderGuru Thanks for your comment.

  0