i built this, with just the application of my html and css

Community feedback

• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  ➨ Add min-height:100vh to properly center the container.

  body{
  min-height: 100vh;
  }
  

  ➨ For non-decorative images give meaningful and descriptive alt like alt= "QR code to Frontend Mentor website".

  ➨ Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

  link.

  ➨ You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.

  I hope you find this helpful.

  Happy coding😄

  Marked as helpful

  1

  ---

  

  PASdeco•40

  @PASdecoPosted over 1 year ago

  @NehalSahu8055 but my design is good?

  1