Skip to content
Submitted almost 2 years ago

I built this landing page using CSS grid

Edoye•170
@DoyeDesigns
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...News homepage
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Can I put the header and footer tag inside the grid container/wrapper?

Should the div container be a main or div tag with a class main?

If I were to animate the hamburger menu icon using CSS how do I still give it the function to open and close when clicked on?

Any feedback is very much appreciated

Community feedback

  • Corvida Raven•680
    @SheGeeksPosted almost 2 years ago

    Nice work on completing this challenge Edoye!

    To answer your questions, your header should remain outside of the grid container/wrapper and body, but your footer should be included within body. Whether you want to include it in the container/wrapper is up to you and the design you wish to achieve, but it's not necessary.

    You should use main instead of div with a class of main. It's the same thing, but using main is semantically correct and accessible.

    I suggest searching google for code examples of animated hamburger menus with CSS only because there are many ways to accomplish this. You'll find plenty of code snippets to examine and choose what works best for your code.

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord