I brute forced my way.

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, great work on this one. As you said mobile is not done, but in general, site looks great, just that horizontal scroll appears.

  Some suggestions would be:

  • Don't use float :>> it is hard to use by now, also you should use flexbox or grid to position item/items properly.
  • It would be great to have a base styling of this:

  html {
    box-sizing: border-boxl
    font-size: 100%;
  }
  
  *,
  *::before,
  *::after {
    box-sizing: inherit
  }
  

  This way, handling an element specially its size will be easier because of the box-sizing

  • Instead of width: 1440px use max-width: 1440px so that the layout won't have a fixed size of 1440px.
  • Always have a main element to wrap the main content of the site. For this use main tag on the .background selector.
  • The illustration being used is only a decorative image. Decorative images should be hidden for screen-reader at all times by using alt="" and aria-hidden="true" to the img tag or only aria-hidden="true" if the image is using svg.
  • Only use descriptive alt on images that are meaningful and adds content to the site otherwise hide the image for screen-reader users.
  • Also, when using img tag, you don't need to add words that relates to "graphic" such as "logo" and others, since img is already an image so no need to describe it as one.
  • Always have an h1 on a page. On this one, you could use h1 for the order summary for now.
  • Also, when using a heading tag, make sure you are not skipping a level. If you use h4 then make sure that h1, h2, h3 are all present.
  • The music-icon should be hidden as well since it is only a decoration so use the method above.
  • Also, table element on this is not suited . table element is usually used when there are list of data that has same fields. For this, a div would be fine.
  • The annual-plan could use a heading tag since it gives overview on what the section would contain.

  Aside from those, great job still on this one.

  Marked as helpful

  1

  ---

  

  Aarón Jiménez•50

  @Vonka-hubPosted about 3 years ago

  @pikamart Thank you a lot!. Had to learn a little bit of git to upload the new corrected files, was fun and tedious. Table element remain the same, but im eyeing another challenge where i can use divs from the start. Also, asked a few tips from a friend and added said tips to the code(the use of vh + min-height and setting 100% to width and height on background selector). Thank you so much for your time. p.s: I'm still learning git, so i created a new branch(master) by accident instead of updating the main one. I changed it to default so the deployment uses its code instead of the old one(main).

  1