Design comparison
Solution retrospective
Please let me know my mistakes i will correct and improve myself. Thanks in advance.
Community feedback
- @FluffyKasPosted over 2 years ago
Hiya,
It doesn't seem to be responsive but the desktop view looks good! I have a few suggestions (apart from making the mobile view as well):
-
You can make the background image cover the whole screen if you add
background-size: cover
to the body. -
I'd remove the "screen image" alt text. Using an img tag makes it self-explanatory that it's an image. An alt text is supposed to be a text description of the image or, if it's just there for decoration, you can leave it empty.
-
Apart from adding a hover animation for the social media icons you could wrap them in <a> tags, they are supposed to be links. Adding an aria-label as well would be useful too.
Good luck! ^^
Marked as helpful1@iamurmaniPosted over 2 years ago@FluffyKas Thank you for the feedback it helps me to improve. Just curious about the alt text. I think this will be helpful in Accessible Rich Internet Applications (ARIA). For people using NVDA or Jass application to access website.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord