huddle-landing-page-with-single-introductory-section-master

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @MaysMajeed 👋🏻

  I have some suggestions to help you fix the accessibility and HTML issues.

  • In your markup, <div class="main-sec">...</div> should be <main class="main-sec">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
  • The logo should have an alt tag, such as: <img src="./images/logo.svg" alt="Huddle">
  • And in order to fix the position of the logo, just remove height and float, then you can reduce width` to adjust the size of the logo.
  • In general, avoid using float in your styling, developers used it way back to put some layouts together. Now, there are technologies such as flexbox and grid, you ought to practice them.
  • Also, I suggest implementing :hover state, which you can find in design folder active-state image, after you implement it you can also add transition: all 0.2s; to the button and the links, this will make :hover smoother.
  • Lastly, it seems like you forgot to add the social media icons at the bottom.

  I hope this was helpful 👨🏻‍💻 other than that, you did a great job, keep it up. Cheers 👾

  1

  ---

  

  Mays•170

  @MaysMajeedPosted about 3 years ago

  Woo @kens-visuals ,you submitted your notes through the entire code ... really appreciated

  I will consider these notes , and for the flex and grid I already using these techniques and the logo is already part of the grid row which I am using here but it didn't go to the very left edge

  Thanks again for the feedback

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @MaysMajeed you're very welcome 😇 I'd really appreciate if you could mark the comment as helpful 🙃

  0

  

  Mays•170

  @MaysMajeedPosted about 3 years ago

  @kens-visuals I already tried to ... but I got this error "Cannot read property 'length' of undefined" ^_^

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @MaysMajeed aww that's pity, but thanks though 🤗

  0