huddle-landing-page-with-single-introductory-section

Community feedback

• 

  Shraddha•485

  @5hraddhaPosted almost 3 years ago

  Hi @Abdul400, First of great job in implementing the design. 👍There are a few suggestions that would like to give for improvements, if you would like:

  1. Instead of using <div> tags as a container every time, you could look into using different HTML semantic tags. For example - you could put logo in <header> tag and rest of the hero section of the webpage in <main> tag. It gives better meaning to the markup and improves accessibility. Freecodecamp Semantic Elements. For more clarity on nesting of HTML elements semantically, you could refer this article - CSS Tricks - How to section your HTML Elements. I usually refer this when I am confused which elements should be nested in which ones.

  2. The social links are not positioned properly. You could try to put them in the bottom-right corner as given in the design. But, what I understand is that the social links are supposed to be hyperlinks that when clicked should take you to the respective pages. So, it would be good to wrap icons in <a> tags and style them such that when hovered over, the cursor should change to pointer.

  Marked as helpful

  0

  ---

  

  Abdihafid Adan•800

  @Abdul400Posted almost 3 years ago

  @5hraddha thank you so much. I will definitely considered the different container. I'd been struggling with making my pages accessible. Will definitely give it a try. I'd even forgotten to put the cursor :pointer styling on the social media links. Will revise right away and push the updates. Thank you so much!!!

  1