Mennatallah Hesham• 1,490
@Mennatallah-Hisham
Posted
Hi Dipesh,
you did great 👍, i ;like that you used aria-label for social links 👏
Here are some suggestions to improve your code:
Alt
- for the logo img , it is better to add the website name/ brand name
<img src="./images/logo.svg" class="header-logo" alt="huddle">
- for decorative img / illustrations you can use aria-hidden="true", which will skip the image for screen reader users.
contact info
- you can use Email link, which is a <a> which gives you the option to specify an email address to send an email.
<a href = "mailto: [email protected]">[email protected]</a>
- you can also link to a telephone number using <a> by using tel:
<a href="tel:+4733378901">
<article>
-
most of your divs can be replaced with <Article> for better semantics, you can read more about <Article> here
Hope you find this helpful, Happy Coding
0
