huddle-landing-page-with-a-single-introductory-section
Design comparison
Solution retrospective
confused in media queries
Community feedback
- @MarlonPassos-gitPosted about 3 years ago
-
You break very quickly from the tablet to mobile version, you should leave a breathing space
-
Your css is compressed, avoid leaving it like this in mentor frontend projects, as this makes it more difficult for us to evaluate ourselves
-
I would increase the title size
-
I think what made the designer complicated was the amount of divs you used to define sessions and having everything placed inside the <main> tag, it would be easier to manipulate, look how I would rewrite
<header> <img> // soon </header> <main> <img> // img of screens <div> <h1>title</h1> <p>paraghafh</p> <a>button<a> // here could be a button too, depending on the case </div> </main> <footer> <ul> <li>facebook</li> <li>twitter</li> <li>instagram</li> </ul> </footer>
I created a draft of this page of how I would structure the elements and using the flex box to align everything, and I also put an example of how to put @media to change your desiner to mobile versions, it's not very detailed but I think you can understand the base, see https://codepen.io/marlonpassos/pen/yLXKvNw
1@Juveria-DalviPosted about 3 years ago@MarlonPassos-git heyy thanks for the feedback I'll surely make the changes and the css is compressed because I use Sass you can find the Sass folder in which there is the uncompressed css
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord