Huddle-landing-page-with-a-single-introductory-section

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 2 years ago

  Hi Sarvotham

  So far so good with your challenge. Here are some things to consider:

  • let your alt values be descriptive for the benefit of assistive technology users. A value like hero-img does not present a clear message to someone who is not able to see the image.
  • the register button seems to be an anchor element , it should kind of navigate to another section or page for the registration
  • the social icons are meant to be links to social media accounts, hence an anchor element should have been used
  • the body has a height: 100vh , change that to min-height: 100vh; . Min-height allows you to accommodate all the content by allowing scroll while height will cut off your content if it does not fit on the screen. Using dev-tools check that on small screens like 375px.

  Marked as helpful

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Sarvotham Gowda, congratulations for your new solution!

  Your solution is perfect and also the design match everything the challenge requires. The only thing I see that can be an issue is the facebook icon that doesnt have the same size of the other social icons, to fix that you can create a class to manage the icon sizes, for example setting all of them with the same class with the size max-width: 24px and height: auto. This way you've a standard for the icon sizes.

  👋 I hope this helps you and happy coding!

  0