huddle-landing-page-with-alternating-feature-blocks-master-Responsive-

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 1 year ago

  Hi Ahmedfrontendlab

  Here are my findings and suggestions after going through your project

  HTML

  • The font family has been imported twice in the head of the HTML , I believe that was an mistake
  • while your have the footer landmark element, you should also have the main landmark element - it is the element that contains the dominant content of the document according to the MDN docs.
  • They is some rules regarding the usage of heading elements , such as:
    • The first heading element of your page should be an h1 element
    • Heading elements should follow an order such that you do not skip heading elements
  • The Get started free button , seems to be meant to navigate to another section or page, making it to be an anchor element
  • most of the footer elements should have been anchor elements. These includes the FAQ, Career, Blog, Facebook, twitter , etc

  CSS

  • using mobile first for styling is considered beneficial
  • font sizes should not be written in px values. The following article will help you with the reasons, why font sizes must never be in px
  • most elements have explicit sizes making it a big task to keep the site responsive. The site is not responsive - the dimensions given in the files like 375 and 1440 represents the size of the given designs . They are not meant to be Media queries. Apply media queries accordingly.

  I would suggest that you start with the QR code component challenge so that you can practice on using semantic html using a less challenging challenge. Remember to use the Discord channel to seek help when you get stuck

  Marked as helpful

  1