huddle-landing-page-with-alternating-feature-blocks-master

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can fix these points:

  • Duplicate property 'margin-top' found.

  53.     margin-top: 1.2rem;
  

  • Too many font-size declarations (35), abstraction needed.

  I hope my feedback will be helpful. You can mark it as useful if so 👍

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  0

  ---

  

  Daniel Lamberti•210

  @daniellambertiPosted over 2 years ago

  @isprutfromua Hi Ivan, thank you for your observations, I will check the code in order to clean it up. Regarding desktop view I am facing some troubles with desktop_preview.jpg. I cannot get the real size of the elements. I have a MacBookPro 13 inches, when I use Inspector with 1440px it is difficult to compare with de .jpg file. Actually, on this challenge, in desktop view, my code is too small, way far smaller than it should be. But this happened just for that reason, that is the size I thought the desktop_design was made. It is not a "code issue".

  0