huddle-landing-page-with-alternating-feature-blocks-master
Design comparison
Solution retrospective
I used a lot of flex-box to position elements like in the header, main and footer, was there another way to position elements inside the header..... etc??
I also used a lot of media queries to get the responsiveness right, was that the right thing to do or there could another way to build responsive layout width less media queries?? Thanks a lot...
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
Regarding you question,
There is nothing wrong with the way you did it using
Flex
. As for themedia queries
that is fine too.If you wish to learn more about responsiveness, here is a link to Google Developer’s site that will teach you how make it 100% responsive:
-
The
Alt Tag
description in the logo needs to be improved upon. The description should state the company name. -
The Illustrations serve no other purpose than to be decorative; They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hides it from assistive technology. -
The
Article
element is not the best choice for wrapping each section. In order to use theArticle
element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). -
The
footer
“phone” and “address” should be wrapped inAnchor Tags
, so users can easily click on them and have the appropriate app open for them. -
The
footer
links need to be wrapped inside anav
element and should only be one single list. -
Your "social media icons" are not displaying properly. You will want to check your code.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord