Vanza Setia• 27,795
@vanzasetia
Posted
Hello, Akash Nagindar Tayde! 👋
Good effort on this challenge! 👍
Some suggestions from me.
- The alternative text for the logo should be the company name. If the alternative text is "logo" then the users might think that this is a "logo website" instead of a "Huddle website".
- Always specify the
type
of thebutton
. In this case, set the type of them astype="button"
. It will prevent the button from behaving unexpectedly. - The logo inside the
footer
needs alternative text too. - The phone number, email, text inside
f-sec2
, text insidef-sec4
, and social media icons are links. So, I recommend wrapping the text content with an anchor tag. - I notice some
!important
keywords in the stylesheet. I would recommend avoiding using it whenever possible. It can create specificity issues and it will make the styling hard to be manipulated. - One example to remove the
!important
. You can set thebackground-color
to thefooter
instead of the child elements.
footer {
background-color: var(--Very-Dark-Cyan);
}
.ft-p {
text-align: right;
/* background-color: var(--Very-Dark-Cyan) !important; */
color: #FFF;
width: 100%;
padding: 10px 14px;
font-size: 14px;
}
.f-main-sec5 {
display: flex;
justify-content: space-evenly;
align-items: center;
/* background-color: var(--Very-Dark-Cyan); */
color: #FFF;
padding-top: 100px;
padding-bottom: 50px;
}
That's it! I hope this helps. Happy coding!
Marked as helpful
1