Design comparison
Solution retrospective
Hello people! When I did this challenge in Visual Studio Code it shows me the background .svg (pseudo-element ::before) but when I upload it to Github it doesn't show it. I am sorry.
I appreciate your comments.
Community feedback
- @PPechmannPosted about 2 years ago
Hi @sneiderDev,
congrats on completing the challenge, well done!
To improve the code a bit, I suggest placing the content inside a
<main>
tag. You can then give thebody
amin-width: 100vh
to cover the full screen and set the background withbackground-image: url("")
.Depending on how the background displays then, you can adjust it with
background-position
and make the necessary tweaks.I hope this feedback helps!
Well done again and keep going 💪
Happy coding 🙂
Patrick
Marked as helpful0@sneiderDevPosted about 2 years ago@PPechmann Hi Patrick! I really appreciate your feedback. I will repeat the challenge to make it better. Thank you!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord