huddle-landing-page-feature-blocks-master (HTML-CSS3)

Community feedback

• 

  Joran Minjon•610

  @DrKlonkPosted over 3 years ago

  Hi Vinicius,

  I like it a lot! The responsiveness is on point and it all looks nice.

  Some minor details:

  • On smaller screens, the headings of the cards could use some room to breathe on the top.
  • The paragraphs of text in the cards should be <p> instead of <span>.
  • The classless div inside of the get-started div could be removed. It also lacks padding when resizing (check 346px for instance)
  • The links in the footer should semantically be a list, I think
  • You have some purposefully empty columns in the footer grid, for spacing. I think that is not that nice. Also, on 983px wide, the column for the first set of links is much smaller than for the second. I would not expect that. I think that extra space is for positioning the social icons properly, but that could be done without the empty columns too. You could also position the items inside the social column differently to fix this.
  • The <picture> tag is mainly used for multiple responsive images. I don't think it is needed here.

  Again, it may look like a lot, but they are all quite minor and the page works as it should.

  Cheers, Joran

  1

  ---

  

  Vinicius Batista•315

  @VbanetyPosted over 3 years ago

  @DrKlonk

  • Thanks a lot for feedback mate, sametimes I have a questions about using list in footer or note, I've received some feedbacks here for to insert DIV instead of list, but if I need to respect the semantic, the better way is to use list, I think.

  • About the <p> tag in the place <span>, I Know that when we're have a text, the correct semantical is <p> tag, I'll fix it.

  However, thanks for all tips.

  0

  

  Vinicius Batista•315

  @VbanetyPosted over 3 years ago

  @DrKlonk

  I fixed the semantical and grid from footer https://huddle-landing-blocks-master-git-main-vbanety.vercel.app/

  1