huddle-landing-page

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hi, Vandana! 👋

  Here are some suggestions for improvements.

  • Image elements must have alt attribute.
  • The most important content on the page is the logo. Without that information, a screen reader user or a search engine will not know what your site/project is called.
  • Not every image needs alt text. If the image does not provide any meaningful content, such as the illustration mockup, consider using empty alt text (alt=””). This saves your screen reader users time as they navigate the page.
  • Always specify the type of the button. It will prevent the button from behaving unexpectedly.
  • Wrap each social media icon with an anchor tag.
  • Give an accessible name to each anchor tag by using aria-label. For example, for the Facebook link, aria-label="Facebook".

  Lastly, I recommend making the site looks closer to the design.

  That's it! I hope this helps!

  0
• 

  Saran•460

  @Saran-73Posted over 2 years ago

  Hi 👋 congratulations.

  • To resolve those accessibility issues enclose your code with <main> tag.
  • Use <h1> tag once .
  • Provide alt attribute to the image tag.
  • It may help to avoid setting margin for the body instead give it 0.
  • Give the hero img the min and Max width values in % or pixels to make it responsive eg max-width:350px would work.
  • Keep practicing focus on Css it will be quite tricky but stay with it you will get better.

  Best of luck👍

  0