Design comparison
Solution retrospective
1)how much would you give it out of 10? 2)things i should focus on making the page more accurately spaced? 3)can i use as much div's as i need to make it more convenient for me? 4)as i am a beginner it usually taking me more lines of code,is that okay?
Community feedback
- @mattstuddertPosted over 4 years ago
Hey Siddhant, nice work on this challenge! I'd give this a solid 6. Your solution looks good, but I would recommend trying to make it responsive. You're setting the
height
on a lot of elements and usingposition: absolute;
in quite a few places. This will make it tricky for you to make the site responsive. Have a look into Flexbox and CSS Grid as these will help you layout your website in a much more scalable and manageable way.To answer your question about the divs, I'd recommend trying not to use too many. It's often best to reduce the amount of code you write. But don't put too much pressure on yourself in the early days. You'll get better with each project! 🙂
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord