Hi there š, Iām Vivek Rajput and this is my solution for this challenge.
š ļø Built With:
HTML5,
CSS3,
Reactjs.
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you
@proabre
Posted
hello there saw your page and it looks berfect but i think you miss the active state ...how abt that
@vivekrajput-93
Posted
@proabre Thank you ...for noticing that...I did recklesness while making this components...I did not notice the active-state..I will be carefull next time..thank you once again.
@Ahmed-Elbald
Posted
Hi,
I've noticed that you haven't applied any of the hover effects in the page, so try to apply it. You can use the fill property with SVGs to do that.
Try to have a main element (only one) in your HTML to improve accessibility (instead of your container for instance), and don't nest it into any parent as it represents a landmark.
It's advisable to use semantic elements with meaningful identifiers. For instance, classes like left and right can be replaced by hero-page-img and hero-page-text
@vivekrajput-93
Posted
@Ahmed-Elbald Thank you brother for noticing that...It is totally my fault that I did not notice the active state...I will be next time..and correct my mistake...thank you once again.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
