@vanzasetia
Posted
Hi, Reza! π
First, I recommend removing JavaScript files from the repository. This website does not use JavaScript and also those files make me feel confused. Also, remove the starter.html
file since it is not used.
For the social media icons hover effect, I recommend using inline SVG instead of <img>
. Then, you can target the path
and set the fill
value to currentColor
. Doing that will make the icon inherit the color of the anchor tag. As a result, you can do a:hover
and then change the color
value to change the color of the icon.
Make all the background images as the background image of the <body>
. Those are decorative images so it is not a problem to make them as background images.
Also, I only expect one media query to switch the mobile layout to the desktop layout. I recommend simplifying the styling. Make the default styling the mobile layout. Do not wrap the styling with a media query. Then, use only a min-width
media query to style the desktop layout.
I hope this helps. Happy coding!
Marked as helpful
@rezajaber
Posted
@vanzasetia of course, aou are right. Thank you for your useful tips :)
@vanzasetia
Posted
@rezajaber No problem! I am glad I could help.