Design comparison
Solution retrospective
Hello !
I found not easy to work with icon at the beginning. But thanks to this challenge, I learned new skills ! I know my code is still far from perfect but each challenge allows me to improve and discover new ways to create. Fell free to comment ;)
Community feedback
- @visualdennissPosted over 1 year ago
Hey there,
nice work!
-
I'd suggest wrapping the content into <main> tag as each page / body should have one <main> tag. Also having a container would make your control over the children easier, as it is now, both image and section are direct children of the body, making it harder to control.
-
I'd suggest using max-width: 890px instead of fixed width for the image, so it was be more responsive in general.
Hope you find this feedback helpful!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord