@JunasVee
Posted
Hi Dawid!
It is great to know that you finished this challenge, your page looks nice and interesting. However, there will always be room and time for improvements. Here are the issues that I found in your solution:
-
On my screen, the text is big enough and clear, great. But when I tried to open it on bigger screen size, it looks so tiny. Perhaps you can make a media query for a viewport larger than 1800x1000 and increase the content's font-size until it is readable on large screens.
-
I saw that you haven't given your background the properties that it needs. It's duplicating or in the Web Development, we call it background repeating.The size is smaller than most desktop screen sizes as well. In the order to fix that, you can put
background-repeat: no-repeat; background-size: cover; background-position: center;on the body tag in CSS. -
I'm not sure why, but I think there should only be 1 footer tag in each document. To fix this, either wrap the social media components in a div instead of a footer tag or delete the attribution with its footer tag. It makes better accessibility.
-
This is the biggest issue, you didn't add the mobile media query. I suggest you make one because it is really important since everyone has a mobile phone and tends to do anything from their phones.
The point of these issues is that your page isn't responsive. But it's all back to you whether you want to improve or not, I'm not forcing you, I'm just here to give you the feedback that I think I better give. Keep going 👍
Marked as helpful
