huddle-landing-page

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  As you want to know specifics about your html, here are some observations / suggestions.

  • don't import scripts in the head unless you're deferring download
  • only import wgat you really need (both of these points relate to performance)
  • only use sections when it is appropriate to do so. This component should only be one section, or maybe one header, one section, one footer
  • let your layout control where lines break, don't force it with <br>s
  • the social links should be a list of links with labels available to an accessibility api stating where those links go
  • alt text needs to be more descriptive on image tags

  I hope that is helpful critique.

  Really do consider doing these challenges without third party stuff though so you work on your own html css and js. I promise it will be worth learning without the frameworks and libraries

  0
• 

  jemeneradev•580

  @jemeneradevPosted almost 4 years ago

  I noticed you are using bootstrap, so my advice is: Try to stay away from css frameworks, as a beginner. Why? You may ask. Because they abstract essential details; details that are assumed you already know and do not want to bother with.

  This true, I find, with frameworks in general. The magical aura around them is enticing, but in the long run, if you do not know how they accomplish a task, you will find yourself frustrated in your inability to change things accordingly.

  0

  ---

  

  Omen•50

  @bobaramPosted almost 4 years ago

  ok. are you saying i must not use bootstrap?

  0

  

  Aayush Sood•1,175

  @soodaayushPosted almost 4 years ago

  @bobaram He is not saying to stop bootstrap. You can use it sometimes use it but as a beginner, it's best to use/learn native CSS. Then, you can understand how CSS works so you wouldn't have no idea of how people who created bootstrap templates were able to do it. Summary: It's best to learn CSS before using frameworks.

  0

  

  Omen•50

  @bobaramPosted almost 4 years ago

  @WarBaddy Ok. I understand . But how do you know i have not learnt native CSS? My original question was about the structure of my html not CSS. I really do not have many problems with CSS.

  0

  

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  @bobaram your design is not responsive at the moment and it doesn't look like you've learnt very much css yet to me.

  I would definitely recommend against using bootstrap while learning. It is making things harder for you.

  0