Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Huddle usando Flexbox

@angelicambs9


Design comparison


SolutionDesign

Solution retrospective


Qualquer feedback é bem vindo :)

Community feedback

Amon 2,560

@A-amon

Posted

Hello! Great attempt~

My suggestions would be:

  1. I wonder why the background doesn't cover the entire page! Set the background-related CSS properties on body, instead of main.

  2. Set a height and width with same values for the social media icons/links.

  3. Have an aria-label attribute for the link. This lets screen reader users know what the link is for.

  4. Wrap the logo in an a tag. Usually the logo is linked to homepage.

  5. Use main for the main content, and not include the header and footer. https://stackoverflow.com/questions/20470345/should-the-header-and-footer-tags-be-inside-the-main-tag/20470513

  6. Don't leave alt empty unless you don't want it to show up when images fail to load or read out to screen reader users.

  7. Set button's border to none. This removes the weird default border it has.

  8. You seem to use box-shadow wrongly for button hence, it isn't showing up. https://www.w3schools.com/cssref/css3_pr_box-shadow.asp

Marked as helpful

1

@angelicambs9

Posted

@A-amon Obrigada pelo feedback, suas dicas foram muito úteis :)

0
Amon 2,560

@A-amon

Posted

@angelicambs9 Glad to help! (Feliz em ajudar! I'm trusting Google Translate on this 😀)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord