Huddle SPA landing page

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, good work on this one.

  Regarding your query, I looked into your css see the declaration in the min-height selector background-image: url(/images/bg-desktop.svg);. Well this works in our venv, but if you were to deploy it at github, using / won't work. Instead you should declare your background image like this background-image: url(../../images/bg-desktop.svg);. Since your css is nested two levels deep, we used ../ 2 times. It will be really helpful to search some path navigations of files.

  Apart from that, your layout resizes well and looks good both in desktop and mobile. My suggestion would be that nesting your social media links inside of a tag. Since they are links right, they should be nested inside it.

  Overall, good work on this one^^

  1

  ---

  

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  @pikamart Also, you can use clamp in the image. So that there will be a minimum and maximum value on it, it is useful when we are resizing. Sample would be that clamp(13rem, 20vw, 25rem) something like that^^

  1

  

  Syahrizal Ardana•330

  @GombengPosted over 3 years ago

  @pikamart thanks for your feedback, i appreciate it :)

  0